Skip to content

TST Fixes estimator checks for classifers when poor_score tag is True#16851

Merged
rth merged 8 commits intoscikit-learn:masterfrom
thomasjpfan:fix_check_classifiers_predictions
Jun 27, 2020
Merged

TST Fixes estimator checks for classifers when poor_score tag is True#16851
rth merged 8 commits intoscikit-learn:masterfrom
thomasjpfan:fix_check_classifiers_predictions

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

Reference Issues/PRs

Fixes #16799

What does this implement/fix? Explain your changes.

Skips tests on predictions for classifiers when the poor_score tag is set to True.

@thomasjpfan thomasjpfan changed the title ENH Fixes estimator checks for classifers when poor_score tag is True TST Fixes estimator checks for classifers when poor_score tag is True Apr 6, 2020
Copy link
Copy Markdown
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrinjalali
Copy link
Copy Markdown
Member

linting issue? But I'm not sure why

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check_classifiers_predictions in check_estimators doesn't support poor_score tag

4 participants