Skip to content

BLD Sets minimal supported numpy version in pyproject.toml#16823

Merged
thomasjpfan merged 5 commits intoscikit-learn:masterfrom
BenjaminLiuPenrose:my_change
Apr 4, 2020
Merged

BLD Sets minimal supported numpy version in pyproject.toml#16823
thomasjpfan merged 5 commits intoscikit-learn:masterfrom
BenjaminLiuPenrose:my_change

Conversation

@BenjaminLiuPenrose
Copy link
Copy Markdown
Contributor

@BenjaminLiuPenrose BenjaminLiuPenrose commented Apr 1, 2020

Reference Issues/PRs

Fixes #16788

What does this implement/fix? Explain your changes.

SciPy>=1.2.2 are built with OpenBLAS
SciPy 1.2 requires oldest-supported-numpy (https://pypi.org/project/oldest-supported-numpy/)
numpy>=1.16.0 starts supporting AIX machine

Any other comments?

For now changes in pyproject.toml files only, other changes in relevant files will be required.

@BenjaminLiuPenrose BenjaminLiuPenrose mentioned this pull request Apr 1, 2020
Closed
rth
rth suggested changes Apr 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminLiuPenrose ! A few comments below.

rth
rth approved these changes Apr 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI passes, thanks for your contribution!

(We need to wait for a second reviewer to merge).

@BenjaminLiuPenrose
Copy link
Copy Markdown
Contributor Author

BenjaminLiuPenrose commented Apr 1, 2020 •
edited
Loading

thanks

Will make an update when I know what to do with the scipy part

@BenjaminLiuPenrose
Copy link
Copy Markdown
Contributor Author

BenjaminLiuPenrose commented Apr 2, 2020

LGTM, assuming CI passes, thanks for your contribution!

(We need to wait for a second reviewer to merge).

Based on this reply [https://mail.python.org/pipermail/scipy-dev/2020-April/024115.html], no need to specify scipy version for different python version at this moment. scipy>=0.19.1 will work as usual

@cmarmo cmarmo modified the milestone: 0.11 Apr 3, 2020
@BenjaminLiuPenrose
Copy link
Copy Markdown
Contributor Author

BenjaminLiuPenrose commented Apr 4, 2020

Any one can point me out why pylatest_pip_openblas_pandas always failed in recent test?

@thomasjpfan
Copy link
Copy Markdown
Member

thomasjpfan commented Apr 4, 2020

There is a temporary fix in #16843 for the CI.

thomasjpfan
thomasjpfan approved these changes Apr 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is your first time contributing, welcome @BenjaminBossan !

LGTM

@thomasjpfan thomasjpfan changed the title minimal supported numpy and scipy version in pyproject.toml BLD Sets minimal supported numpy version in pyproject.toml Apr 4, 2020
@thomasjpfan thomasjpfan merged commit 395cfd7 into scikit-learn:master Apr 4, 2020
@BenjaminLiuPenrose
Copy link
Copy Markdown
Contributor Author

BenjaminLiuPenrose commented Apr 5, 2020

Thanks

@BenjaminLiuPenrose BenjaminLiuPenrose deleted the my_change branch April 5, 2020 02:22
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@BenjaminLiuPenrose @gio8tisu
BLD Sets minimal supported numpy version in pyproject.toml (scikit-le…
5f4e8fd 
…arn#16823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

+1 more reviewer

@rth rth rth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module:linear_model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Specify minimal supported numpy and scipy version in pyproject.toml

4 participants

@BenjaminLiuPenrose @thomasjpfan @rth @cmarmo