CLN Removes unneeded code in histgradientboosting#16820
Merged
NicolasHug merged 1 commit intoscikit-learn:masterfrom Apr 1, 2020
Merged
CLN Removes unneeded code in histgradientboosting#16820NicolasHug merged 1 commit intoscikit-learn:masterfrom
NicolasHug merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
Thanks, somehow these got re-introduced in the code because they were already removed in https://github.com/scikit-learn/scikit-learn/pull/15686/files :p Failure is unrelated so we can merge |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is already called here:
scikit-learn/sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py
Lines 340 to 346 in a5dfba9
CC @NicolasHug