[MRG] DOC Use default matplotlib colors in example#16808
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Mar 31, 2020
Merged
[MRG] DOC Use default matplotlib colors in example#16808jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
see #5435, though matplotlib has changed its defaults in the meantime |
Member
Author
|
I thought the new matplotlib default was OK wrt color blindness now? Maybe @adrinjalali knows more about this? |
Member
|
I can confirm they're colorblind friendly, I can see them ;) |
adrinjalali
approved these changes
Mar 31, 2020
Member
|
I am supporting the use of matplotlib default, they have definitely improved. |
jnothman
approved these changes
Mar 31, 2020
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
This was referenced Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the MPL default are pretty good now so no need for custom ones I guess?