Skip to content

[MRG] DOC simplify pipeline docstring example#16780

Merged
adrinjalali merged 2 commits intoscikit-learn:masterfrom
NicolasHug:pipeline_example
Mar 28, 2020
Merged

[MRG] DOC simplify pipeline docstring example#16780
adrinjalali merged 2 commits intoscikit-learn:masterfrom
NicolasHug:pipeline_example

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

I think it's worth simplifying because:

  • users are scared of pipelines in general, so let's show them it's very easy
  • all of the things in the example are well documented in the UG (which is short too so that's good)
  • the anova example has a dedicated example which is also linked in the UG

Copy link
Copy Markdown
Member

@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely approve simpler examples in docstrings

Co-Authored-By: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
@adrinjalali adrinjalali merged commit a84ba0c into scikit-learn:master Mar 28, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
* Simplified exmaple

* Update sklearn/pipeline.py

Co-Authored-By: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>

Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants