Skip to content

MNT New options for higgs-boson benchmark#16779

Merged
NicolasHug merged 2 commits intoscikit-learn:masterfrom
NicolasHug:higgs_new_params
Mar 27, 2020
Merged

MNT New options for higgs-boson benchmark#16779
NicolasHug merged 2 commits intoscikit-learn:masterfrom
NicolasHug:higgs_new_params

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

Added 2 options to:

  • set joblib memory location: useful on clusters or machines where there's a dedicated scratch storage other than /tmp
  • bypass predictions: useful when you only care about fit time since prediction can take a significant amount of time

Also lightly refactored to avoid duplicated code

ping @rth @thomasjpfan easy one?

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasHug !

@NicolasHug
Copy link
Copy Markdown
Member Author

Thanks for the review, since this is just benchmark code with backward compat, I'll merge

@NicolasHug NicolasHug changed the title [MRG] MNT higgs-boson benchmark update MNT New options for higgs-boson benchmark Mar 27, 2020
@NicolasHug NicolasHug merged commit 0a866ec into scikit-learn:master Mar 27, 2020
@NicolasHug NicolasHug deleted the higgs_new_params branch March 27, 2020 16:02
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants