DOC Change number of classes in lfw_pair documentation#16761
Merged
NicolasHug merged 2 commits intoscikit-learn:masterfrom Mar 25, 2020
Merged
DOC Change number of classes in lfw_pair documentation#16761NicolasHug merged 2 commits intoscikit-learn:masterfrom
NicolasHug merged 2 commits intoscikit-learn:masterfrom
Conversation
Previous number of 5749 was actually the size of the set from which the pair of face labels were sampled. It was misleading because the task isn't to predict the label of the pair but wether or not the two faces belong to the same person, hence a binary classification task.
TomDLT
approved these changes
Mar 25, 2020
Member
|
This dataset is clearly for binary classification, but could it also be used for multiclass classification ? |
Contributor
Author
|
I don't think so, there is a separate dataset called "lfw_people" that has 5749 classes. I think we can only do binary classifcation with lfw_pairs https://scikit-learn.org/stable/modules/generated/sklearn.datasets.fetch_lfw_people.html |
NicolasHug
approved these changes
Mar 25, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
sounds fair.
Also the target array is only ones and zeros
Thanks @lucgiffon
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous number of 5749 was actually the size of the set from which the pair of face labels were sampled. It was misleading because the task isn't to predict the label of the pair but wether or not the two faces belong to the same person, hence a binary classification task.
Reference Issues/PRs
Fix #16757