Skip to content

DOC phrasing improvements and typos#16744

Merged
NicolasHug merged 8 commits intoscikit-learn:masterfrom
raduspaimoc:DocumentationReview
Apr 9, 2020
Merged

DOC phrasing improvements and typos#16744
NicolasHug merged 8 commits intoscikit-learn:masterfrom
raduspaimoc:DocumentationReview

Conversation

@raduspaimoc
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @raduspaimoc , made a few comments.

(Just FYI, a few of your suggestions are converting UK spelling to US, we're typically not too strict on these ;) )

@NicolasHug NicolasHug changed the title Documentation reviewed. [MRG] DOC phrasing improvements and typos Mar 23, 2020
@raduspaimoc raduspaimoc reopened this Mar 23, 2020
@raduspaimoc
Copy link
Copy Markdown
Contributor Author

@NicolasHug thanks for your suggestions. Didn't want to bother you, I just want to contribute and this was the simplest way that I come up with. Viewing the open issues with the good first issue label and their demand, is there any way in which I can contribute without bothering anyone or I just have to wait for new first issues?

Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't worry you're not bothering anyone @raduspaimoc , we always welcome contributions

The PRs will always be reviewed and need approval by 2 core devs (for PRs like this one that only touch the doc, one is often enough)

The best way is to watch out for the "good first issue" label, but you can also browse the docs and submit PRs to clarify things you think could be clearer and / or fix typos!

Last few comments and we're good to go!

raduspaimoc and others added 5 commits March 23, 2020 13:57
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
@NicolasHug
Copy link
Copy Markdown
Member

THanks @raduspaimoc ! merging

@NicolasHug NicolasHug changed the title [MRG] DOC phrasing improvements and typos DOC phrasing improvements and typos Apr 9, 2020
@NicolasHug NicolasHug merged commit f45c0c0 into scikit-learn:master Apr 9, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants