DOC Update docstring of RFs regarding max_samples#16738
Merged
NicolasHug merged 3 commits intoscikit-learn:masterfrom Mar 21, 2020
Merged
DOC Update docstring of RFs regarding max_samples#16738NicolasHug merged 3 commits intoscikit-learn:masterfrom
NicolasHug merged 3 commits intoscikit-learn:masterfrom
Conversation
NicolasHug
approved these changes
Mar 21, 2020
sklearn/ensemble/_forest.py
Outdated
Comment on lines
+887
to
+889
| The sub-sample size is controlled with the max_samples parameter if | ||
| bootstrap=True (default), otherwise the whole dataset is used to build each | ||
| tree. |
Member
There was a problem hiding this comment.
Suggested change
| The sub-sample size is controlled with the max_samples parameter if | |
| bootstrap=True (default), otherwise the whole dataset is used to build each | |
| tree. | |
| The sub-sample size is controlled with the `max_samples` parameter if | |
| `bootstrap=True` (default), otherwise the whole dataset is used to build each | |
| tree. |
Contributor
Author
There was a problem hiding this comment.
Thanks! I copy-pasted the rendered text instead of the markdown source...
sklearn/ensemble/_forest.py
Outdated
Comment on lines
+1205
to
+1207
| The sub-sample size is controlled with the max_samples parameter if | ||
| bootstrap=True (default), otherwise the whole dataset is used to build each | ||
| tree. |
Member
There was a problem hiding this comment.
Suggested change
| The sub-sample size is controlled with the max_samples parameter if | |
| bootstrap=True (default), otherwise the whole dataset is used to build each | |
| tree. | |
| The sub-sample size is controlled with the `max_samples` parameter if | |
| `bootstrap=True` (default), otherwise the whole dataset is used to build each | |
| tree. |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16733
What does this implement/fix? Explain your changes.
This small PR updates the description of the sub-sample size to take into account the addition of the
max_samplesparameter in version 0.22.