Skip to content

MNT Raise error when parameter isn't correct in SVC and…#16736

Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
NicolasHug:decision_func_shape_bad
Apr 5, 2020
Merged

MNT Raise error when parameter isn't correct in SVC and…#16736
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
NicolasHug:decision_func_shape_bad

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

Also parametrized a test while we're at it

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasHug

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title [MRG] MNT Raise error when parameter isn't correct in SVC and NuSVC MNT Raise error when parameter isn't correct in SVC and… Apr 5, 2020
@thomasjpfan thomasjpfan merged commit 16b3bf7 into scikit-learn:master Apr 5, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants