Skip to content

[MRG] DOC Minor update to random state glossary#16735

Merged
rth merged 3 commits intoscikit-learn:masterfrom
NicolasHug:random_state_glossary_update
Mar 25, 2020
Merged

[MRG] DOC Minor update to random state glossary#16735
rth merged 3 commits intoscikit-learn:masterfrom
NicolasHug:random_state_glossary_update

Conversation

@NicolasHug
Copy link
Copy Markdown
Member

Just added a few details

@adrinjalali
Copy link
Copy Markdown
Member

I like the changes. But I noticed the description (before and after the change) has a focus on fit and split, while the random state can be used in other places as well. For instance, we have the random state in k_means function, or some estimator may use that in predict (which makes sense in the context of fairness sometimes). It'd be nice if we could clarify that.

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicolasHug !

@rth rth merged commit c5d1d45 into scikit-learn:master Mar 25, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants