API make __init__ args in ensemble kwonly#16724
Merged
jnothman merged 5 commits intoscikit-learn:masterfrom Mar 31, 2020
Merged
API make __init__ args in ensemble kwonly#16724jnothman merged 5 commits intoscikit-learn:masterfrom
jnothman merged 5 commits intoscikit-learn:masterfrom
Conversation
jnothman
reviewed
Mar 19, 2020
Member
jnothman
left a comment
There was a problem hiding this comment.
This is a bit trickier :)
I'm okay with this, but some of your decisions are more conservative than those I might have taken.
Member
Author
|
@jnothman does it look better now? |
jnothman
approved these changes
Mar 24, 2020
amueller
reviewed
Mar 30, 2020
sklearn/ensemble/_stacking.py
Outdated
|
|
||
| @abstractmethod | ||
| def __init__(self, estimators, final_estimator=None, cv=None, | ||
| def __init__(self, estimators, *, final_estimator=None, cv=None, |
Member
There was a problem hiding this comment.
final_estimator should always be supplied, right? The default seems like a fallback, not sure why we even have it. Not a strong opinion though.
amueller
approved these changes
Mar 30, 2020
Member
amueller
left a comment
There was a problem hiding this comment.
lgtm. I would allow positional final_estimator but either is fine with me.
Member
Author
|
@amueller allowing positional |
Member
|
I'm happy to allow positional final estimator.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards #15005
tackles the ensemble module