Skip to content

API make __init__ params in decomposition kwonly#16722

Merged
adrinjalali merged 3 commits intoscikit-learn:masterfrom
adrinjalali:kwargs/decomposition
Mar 31, 2020
Merged

API make __init__ params in decomposition kwonly#16722
adrinjalali merged 3 commits intoscikit-learn:masterfrom
adrinjalali:kwargs/decomposition

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

@adrinjalali adrinjalali commented Mar 19, 2020

towards #15005

tackles the decomposition module.

Copy link
Copy Markdown
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this DOC?

@adrinjalali adrinjalali changed the title DOC make __init__ params in decomposition kwonly API make __init__ params in decomposition kwonly Mar 19, 2020
@adrinjalali
Copy link
Copy Markdown
Member Author

Why is this DOC?

Cause I've clearly been involved in more DOC stuff than API that "DOC" is my automatic reflex prefix to PRs lol.

@adrinjalali adrinjalali merged commit d6d624d into scikit-learn:master Mar 31, 2020
@adrinjalali adrinjalali deleted the kwargs/decomposition branch March 31, 2020 08:28
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
* DOC make __init__ params in decomposition kwonly

* test fixes

* pep8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants