OneVsOneClassifier: added an example to the documentation#16700
Merged
glemaitre merged 5 commits intoscikit-learn:masterfrom May 12, 2020
Merged
OneVsOneClassifier: added an example to the documentation#16700glemaitre merged 5 commits intoscikit-learn:masterfrom
glemaitre merged 5 commits intoscikit-learn:masterfrom
Conversation
glemaitre
reviewed
Mar 16, 2020
Member
glemaitre
left a comment
There was a problem hiding this comment.
A couple of changes but it looks good
Contributor
Author
|
@glemaitre I have added the requested changes |
adrinjalali
approved these changes
Mar 16, 2020
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Otherwise LGTM, thanks @j0rd1smit
sklearn/multiclass.py
Outdated
Comment on lines
+530
to
+537
| >>> clf.predict(X_test) | ||
| array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | ||
| 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, | ||
| 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, | ||
| 1, 2, 1, 2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 1, 1, 1, 1, 1, 1, 1, 1, | ||
| 1, 1, 1, 1, 1, 1, 1, 1, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, | ||
| 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, | ||
| 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2]) |
Member
There was a problem hiding this comment.
I think showing the output of even only one input i.e. X_test[0, :] should be enough.
glemaitre
approved these changes
May 12, 2020
Member
|
@j0rd1smit I just pushed a commit with the suggestion of @adrinjalali and I will merge when the CIs are happy. Thanks for your work. |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
May 18, 2020
adrinjalali
pushed a commit
that referenced
this pull request
May 19, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The to do list in issue #3846 mentioned that the
OneVsOneClassifierclassifier needed an example in its documentation. I saw the was already an example in the user guide so I added this example to the documentation.