Skip to content

DOC replace boston plot_outlier_detection#16687

Merged
glemaitre merged 4 commits intoscikit-learn:masterfrom
lucyleeow:DOC_outlier
Mar 24, 2020
Merged

DOC replace boston plot_outlier_detection#16687
glemaitre merged 4 commits intoscikit-learn:masterfrom
lucyleeow:DOC_outlier

Conversation

@lucyleeow
Copy link
Copy Markdown
Member

Towards #16155

What does this implement/fix? Explain your changes.

Replaces data in plot_outlier_detection_housing.py from boston to wine recognition.

Previous:
image

New:
image

The first example is slightly different (as the observations confounded into one was quite unique to the boston data set) but still shows a main cluster and deviation of non robust empirical covariance estimate. I assumed that 'confounding' was referring to data problems resulting in many observations being the same so changed the explanatory text. In the new example it is more a main 'primary' cluster with outlying points, possibly another small cluster.

ping @ogrisel

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Thanks. Could you maybe increase the width of the plots so that the legend fits in the plot maybe?

Also, while you're at it, it'd be really nice if you could divide the example into sections for the two examples the same way it's done in this example for instance.

@glemaitre
Copy link
Copy Markdown
Member

I like the new data. @lucyleeow since you know perfectly sphinx-gallery ;P, do you think that it would be intuitive to make it a notebook style meaning to plot the first figure in the section First example and the second one in the second section. It meanly requires to move code around but it will be better I think.

@lucyleeow
Copy link
Copy Markdown
Member Author

Have separated each example and plot so that they are together and the legend fits in the plot now. Thanks @glemaitre and @adrinjalali

@lucyleeow
Copy link
Copy Markdown
Member Author

ping @glemaitre

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucyleeow . LGTM.

@glemaitre glemaitre merged commit 3a72410 into scikit-learn:master Mar 24, 2020
@glemaitre
Copy link
Copy Markdown
Member

Thanks @lucyleeow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants