DOC: wording in linear model interpretation#16680
Merged
glemaitre merged 8 commits intoscikit-learn:masterfrom Mar 13, 2020
Merged
DOC: wording in linear model interpretation#16680glemaitre merged 8 commits intoscikit-learn:masterfrom
glemaitre merged 8 commits intoscikit-learn:masterfrom
Conversation
glemaitre
approved these changes
Mar 12, 2020
Member
glemaitre
left a comment
There was a problem hiding this comment.
I am happy with the changes.
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
glemaitre
approved these changes
Mar 12, 2020
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
cmarmo
approved these changes
Mar 12, 2020
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
…on.py Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…on.py Co-Authored-By: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…on.py Co-Authored-By: Chiara Marmo <cmarmo@users.noreply.github.com>
…on.py Co-Authored-By: Chiara Marmo <cmarmo@users.noreply.github.com>
Member
Author
|
@cmarmo and @glemaitre I've addressed your comments. Thank you! I think that it would be useful to have a review from a native-English speaker. @jnothman : you reviewed the original PR. This one should (hopefully) not take you long. Thanks! |
NicolasHug
approved these changes
Mar 12, 2020
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
examples/inspection/plot_linear_model_coefficient_interpretation.py
Outdated
Show resolved
Hide resolved
…on.py Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
…on.py Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
Member
Author
|
To avoid straining our reviewing resources, if @jnothman doesn't have the time to look at this today, I suggest that we merge: reviewing time is a bottleneck, and Joel probably has better things to do than validating my nitpicks in English. |
Member
|
Merging then with the current approvals. |
ashutosh1919
pushed a commit
to ashutosh1919/scikit-learn
that referenced
this pull request
Mar 13, 2020
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes in wording in the example. Nothing but English and a few statistical pointers.