Skip to content

DOC Add note on bias induced by dropping categories in OneHotEncoder#16679

Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
ogrisel:doc-onehot-drop-bias
Mar 13, 2020
Merged

DOC Add note on bias induced by dropping categories in OneHotEncoder#16679
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
ogrisel:doc-onehot-drop-bias

Conversation

@ogrisel
Copy link
Copy Markdown
Member

@ogrisel ogrisel commented Mar 12, 2020

Small note on the use of drop in OneHotEncoder.

@ogrisel
Copy link
Copy Markdown
Member Author

ogrisel commented Mar 12, 2020

One could argue that most hyperparameters induce a bias but maybe this one would tend to be more overlooked than others by practitioners.

@glemaitre glemaitre changed the title Add note on bias induced by dropping categories in OneHotEncoder DOC Add note on bias induced by dropping categories in OneHotEncoder Mar 13, 2020
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 6ee1597 into scikit-learn:master Mar 13, 2020
ashutosh1919 pushed a commit to ashutosh1919/scikit-learn that referenced this pull request Mar 13, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants