CI Check for unused imports when linting#16678
Merged
adrinjalali merged 3 commits intoscikit-learn:masterfrom Mar 12, 2020
Merged
CI Check for unused imports when linting#16678adrinjalali merged 3 commits intoscikit-learn:masterfrom
adrinjalali merged 3 commits intoscikit-learn:masterfrom
Conversation
ogrisel
approved these changes
Mar 12, 2020
Member
|
YAY Thank you @rth!! |
ashutosh1919
pushed a commit
to ashutosh1919/scikit-learn
that referenced
this pull request
Mar 13, 2020
* Check for missing imports in linting * Exclude externals * Remove unused imports
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
* Check for missing imports in linting * Exclude externals * Remove unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check for unused imports with flake8 to the linter CI job. This should helps catching them when refactoring.
Otherwise we have to do this manually every year or so (e.g. #14021 #16665 )