Skip to content

MNT Removes unused private attributes in IsotonicRegression#16675

Merged
ogrisel merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:remove_unused_X_y_isotonic
Mar 12, 2020
Merged

MNT Removes unused private attributes in IsotonicRegression#16675
ogrisel merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:remove_unused_X_y_isotonic

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

These private attributes are unused since X_ and y_ are already removed.

Copy link
Copy Markdown
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the CI goes green, nice!

Copy link
Copy Markdown
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ogrisel ogrisel merged commit 0e4996d into scikit-learn:master Mar 12, 2020
ashutosh1919 pushed a commit to ashutosh1919/scikit-learn that referenced this pull request Mar 13, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants