Merged
Conversation
jnothman
approved these changes
Mar 4, 2020
Member
|
Thanks for the pull request! Please make the title of the PR more descriptive. The title will become the commit message when this is merged. |
adrinjalali
approved these changes
Mar 5, 2020
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Thanks @JohanWork for the PR. I see this is your first PR, welcome to the community :)
As @jnothman says, a more descriptive PR title would help. It will also help us find the PRs easier.
Member
|
Looks like the bug has not been fixed yet when it comes to authorship: 83ec08b The previous behavior should be restored in ~ 24 hours: #16640 (comment) |
Contributor
Author
|
Thanks for the merge! Guess that a heading was added in the merge, happy to have contributed and will continue! |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 6, 2020
Co-authored-by: JohanWork
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 6, 2020
This reverts commit 83ec08b.
Closed
ashutosh1919
pushed a commit
to ashutosh1919/scikit-learn
that referenced
this pull request
Mar 13, 2020
Co-authored-by: JohanWork
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
Co-authored-by: JohanWork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #16384
What does this implement/fix? Explain your changes.
The implementation updates documentation for sklearn.cluster.DBSCAN regarding n_jobs for precomputed distances
Any other comments?
I screwed up the previous pr and thought it was easier redoing it all. And make it correct!