[MRG] Rename _parallel_fit_estimator to _fit_single_estimator#16599
Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom Feb 29, 2020
Merged
[MRG] Rename _parallel_fit_estimator to _fit_single_estimator#16599thomasjpfan merged 2 commits intoscikit-learn:masterfrom
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
Conversation
added 2 commits
February 28, 2020 15:38
…ck of parallelism in the method
This was referenced Feb 29, 2020
NicolasHug
approved these changes
Feb 29, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @wderose , LGTM if all goes green!
thomasjpfan
approved these changes
Feb 29, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
I see this is your first time contributing, welcome!
LGTM
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
…t lack of parallelism in the method (scikit-learn#16599)
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
…t lack of parallelism in the method (scikit-learn#16599)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #16595
What does this implement/fix? Explain your changes.
Renames a non-public API method from
_parallel_fit_estimatorto_fit_single_estimatorto better reflect the serial/single-threaded operation actually performed by the method. No parallel calls are made in the method. The parallel part will come when we pass this method to theParallelclass, as we do here and here.In PR #16539, it was suggested that we rename this method to
_fit_single_estimatorto clarify the usage intent. See this comment specifically: https://github.com/scikit-learn/scikit-learn/pull/16539/files#r385937964Any other comments?