DOC: Mark the sentence end in classification_report#16411
Merged
NicolasHug merged 1 commit intoscikit-learn:masterfrom Feb 10, 2020
Merged
Conversation
Mark the sentence end in `classification_report` method docstring.
Member
|
Fine with me but I am not sure we are consistent in our code base. If the de-facto convention is half and half, maybe we should not open individual PRs for each docstring. |
Contributor
Author
|
@ogrisel Thanks for the review. sorry, I did not pretend to address all such occurrences throughout the whole code base; I was reading the documentation on that module and saw that a fair number of docstrings or those that I checked were using that convention. In any case, I believe that rather than a convention, using punctuation helps to mark the end of the sentence/paragraph in the docstring. I understand your point and I do share that if this is to be done consistently for the whole code-base, a single PR should address all occurrences. |
NicolasHug
approved these changes
Feb 10, 2020
classification_report method docstringclassification_report
Member
|
thanks @jhlegarreta |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the sentence end in
classification_reportmethod docstring.