Skip to content

[DOC] Update random_state descriptions for mutual_info, unsupervised, .… (4)#16320

Merged
adrinjalali merged 5 commits intoscikit-learn:masterfrom
DatenBiene:utils_random_doc
Feb 7, 2020
Merged

[DOC] Update random_state descriptions for mutual_info, unsupervised, .… (4)#16320
adrinjalali merged 5 commits intoscikit-learn:masterfrom
DatenBiene:utils_random_doc

Conversation

@DatenBiene
Copy link
Copy Markdown
Contributor

Reference Issue/PR:
partially addressed #10548

Updated the documentation for random_state in :

sklearn/feature_selection/_mutual_info.py - 226, 335, 414
sklearn/metrics/cluster/_unsupervised.py - 80
sklearn/utils/_testing.py - 521
sklearn/utils/init.py - 478, 623

Only added the key sentence :
Pass an int for reproducible output across multiple function calls.
See :term:Glossary <random_state>.

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nitpicks

DatenBiene and others added 3 commits January 31, 2020 16:20
Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
@DatenBiene
Copy link
Copy Markdown
Contributor Author

I have addressed your comments @jeremiedbb :D

@adrinjalali adrinjalali merged commit 4a3b436 into scikit-learn:master Feb 7, 2020
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
… .… (4) (scikit-learn#16320)

* Update random_state doc for mutual_info.py, unsupervised.py, testing.py and utils/init.py

* Update comments from pr

* Update sklearn/metrics/cluster/_unsupervised.py

Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

* Update sklearn/utils/__init__.py

Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

* Update sklearn/utils/__init__.py

Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
… .… (4) (scikit-learn#16320)

* Update random_state doc for mutual_info.py, unsupervised.py, testing.py and utils/init.py

* Update comments from pr

* Update sklearn/metrics/cluster/_unsupervised.py

Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

* Update sklearn/utils/__init__.py

Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

* Update sklearn/utils/__init__.py

Co-Authored-By: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants