Skip to content

DOC more informative description of random state in _rbm.py#16318

Merged
rth merged 3 commits intoscikit-learn:masterfrom
GregoireMialon:rbm_doc
Feb 3, 2020
Merged

DOC more informative description of random state in _rbm.py#16318
rth merged 3 commits intoscikit-learn:masterfrom
GregoireMialon:rbm_doc

Conversation

@GregoireMialon
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Ticks one box in #10548 (_rbm.py)

What does this implement/fix? Explain your changes.

More informative description of what random_states influences

@jeremiedbb Paris Sprint

Copy link
Copy Markdown
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @GregoireMialon. Just a couple of comments, mainly for readability.

Copy link
Copy Markdown
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GregoireMialon !

@rth rth changed the title [MRG] more informative description of random state in _rbm.py DOC more informative description of random state in _rbm.py Feb 3, 2020
@rth rth merged commit ad2af90 into scikit-learn:master Feb 3, 2020
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants