DOC add a coc reference to the main page#16262
Merged
glemaitre merged 2 commits intoscikit-learn:masterfrom Jan 29, 2020
Merged
DOC add a coc reference to the main page#16262glemaitre merged 2 commits intoscikit-learn:masterfrom
glemaitre merged 2 commits intoscikit-learn:masterfrom
Conversation
rth
approved these changes
Jan 28, 2020
Member
rth
left a comment
There was a problem hiding this comment.
Minor comment otherwise LGTM, thanks!
doc/templates/index.html
Outdated
| <li><strong>Questions?</strong> See <a href="faq.html">FAQ</a> and <a href="https://stackoverflow.com/questions/tagged/scikit-learn">stackoverflow</a></li> | ||
| <li><strong>Mailing list:</strong> <a href="https://mail.python.org/mailman/listinfo/scikit-learn">scikit-learn@python.org</a></li> | ||
| <li><strong>Gitter:</strong> <a href="https://gitter.im/scikit-learn/scikit-learn">gitter.im/scikit-learn</a></li> | ||
| <li>All communication on all channels should respect <a href="https://www.python.org/psf/conduct/">PSF's code of conduct</a></li> |
Member
There was a problem hiding this comment.
Maybe "Communication on all channel" to be less redundant?
Also needs a . at the end.
amueller
approved these changes
Jan 28, 2020
amueller
approved these changes
Jan 28, 2020
GaelVaroquaux
approved these changes
Jan 29, 2020
Member
GaelVaroquaux
left a comment
There was a problem hiding this comment.
I approve, but also pushing toward the slightly shorter formulation
doc/templates/index.html
Outdated
| <li><strong>Questions?</strong> See <a href="faq.html">FAQ</a> and <a href="https://stackoverflow.com/questions/tagged/scikit-learn">stackoverflow</a></li> | ||
| <li><strong>Mailing list:</strong> <a href="https://mail.python.org/mailman/listinfo/scikit-learn">scikit-learn@python.org</a></li> | ||
| <li><strong>Gitter:</strong> <a href="https://gitter.im/scikit-learn/scikit-learn">gitter.im/scikit-learn</a></li> | ||
| <li>All communication on all channels should respect <a href="https://www.python.org/psf/conduct/">PSF's code of conduct</a></li> |
Member
There was a problem hiding this comment.
Suggested change
| <li>All communication on all channels should respect <a href="https://www.python.org/psf/conduct/">PSF's code of conduct</a></li> | |
| <li>Communication on all channels should respect <a href="https://www.python.org/psf/conduct/">PSF's code of conduct</a></li> |
Member
|
@adrinjalali Thanks for taking care of this. |
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a link to psf's coc to the main page. Not sure about the wording, open to suggestions :)
Seems like having it on the website is the consensus from #16139
CC: @scikit-learn/core-devs