DOC Adds example for empirical_covariance#16229
Merged
thomasjpfan merged 2 commits intoscikit-learn:masterfrom Feb 4, 2020
Merged
DOC Adds example for empirical_covariance#16229thomasjpfan merged 2 commits intoscikit-learn:masterfrom
thomasjpfan merged 2 commits intoscikit-learn:masterfrom
Conversation
glemaitre
approved these changes
Jan 26, 2020
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Only some alignment issue.
| -------- | ||
| >>> from sklearn.covariance import empirical_covariance | ||
| >>> X = [[1,1,1],[1,1,1],[1,1,1], | ||
| ... [0,0,0],[0,0,0],[0,0,0]] |
Member
There was a problem hiding this comment.
Suggested change
| ... [0,0,0],[0,0,0],[0,0,0]] | |
| ... [0,0,0],[0,0,0],[0,0,0]] |
| ... [0,0,0],[0,0,0],[0,0,0]] | ||
| >>> empirical_covariance(X) | ||
| array([[0.25, 0.25, 0.25], | ||
| [0.25, 0.25, 0.25], |
Member
There was a problem hiding this comment.
Suggested change
| [0.25, 0.25, 0.25], | |
| [0.25, 0.25, 0.25], |
| >>> empirical_covariance(X) | ||
| array([[0.25, 0.25, 0.25], | ||
| [0.25, 0.25, 0.25], | ||
| [0.25, 0.25, 0.25]]) |
Member
There was a problem hiding this comment.
Suggested change
| [0.25, 0.25, 0.25]]) | |
| [0.25, 0.25, 0.25]]) |
| array([[0.25, 0.25, 0.25], | ||
| [0.25, 0.25, 0.25], | ||
| [0.25, 0.25, 0.25]]) | ||
|
|
Contributor
|
Hi @fraboeni, one approval already, and the failing checks have nothing to do with your modifications. Do you think you will find some time to finalize this? Thanks for your time! |
thomasjpfan
approved these changes
Feb 4, 2020
Member
thomasjpfan
left a comment
There was a problem hiding this comment.
Thank you for the PR @fraboeni !
thomasjpfan
pushed a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with @magda-zielinska
Reference Issues/PRs
#3846
What does this implement/fix? Explain your changes.
Adds an example to the _empirical_covariance function