[MRG] MNT Adds filters to jinja template#16133
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Feb 5, 2020
Merged
Conversation
Member
|
what issue is this addressing? |
Member
Author
|
When building the docs in sphinx 2.3.1 there was a formatting issue cased by not escaping html characters. This type of link is escaped in the links surrounding the one in the PR: |
Member
Author
|
For example: |
Member
|
It is weird. I don't see the error on stable. Is related to the browser as well? |
Member
Author
I see it on all browers. It only happens on some menus when the html is not correctly escaped and only on newer versions of sphinx (2.3.1). For example, it appears on |
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Feb 22, 2020
panpiort8
pushed a commit
to panpiort8/scikit-learn
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tag stripping to jinja template