Skip to content

DOC random_state in _logistic#15729

Merged
glemaitre merged 5 commits intoscikit-learn:masterfrom
MDouriez:15222_logistic
Jan 8, 2020
Merged

DOC random_state in _logistic#15729
glemaitre merged 5 commits intoscikit-learn:masterfrom
MDouriez:15222_logistic

Conversation

@MDouriez
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

#15222

What does this implement/fix? Explain your changes.

Add links to the glossary

Any other comments?

@MDouriez
Copy link
Copy Markdown
Contributor Author

MDouriez commented Dec 5, 2019

@NicolasHug Let me know if this seems useful :)

Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MDouriez ! Better docs are always helpful.

A few comments but LGTM when addressed

@glemaitre
Copy link
Copy Markdown
Member

I solved the conflict and pushed a couple of nitpicks. Will merge when CIs are green.

@glemaitre glemaitre merged commit 3f9f7d5 into scikit-learn:master Jan 8, 2020
@glemaitre
Copy link
Copy Markdown
Member

Thanks @MDouriez

@MDouriez
Copy link
Copy Markdown
Contributor Author

MDouriez commented Jan 8, 2020

Thank you @glemaitre !

thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Feb 22, 2020
panpiort8 pushed a commit to panpiort8/scikit-learn that referenced this pull request Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants