DOC improve random_state docstring random modue#15576
DOC improve random_state docstring random modue#15576glemaitre merged 4 commits intoscikit-learn:masterfrom happilyeverafter95:document_random_state
Conversation
|
I'm not convinced that a randomisation utility needs this kind of change.
We need this change where there is an algorithm that incorporates
randomness more subtly.
|
|
@jnothman, @NicolasHug , I think that @happilyeverafter95 modified this file picking it from the list available in #15222. This list is automatically generated and I'm cleaning it for the next sprints. If you all agree that this file should not be touched I will remove it from the new list, please let us know. Anyway thanks Mandy for your work! And sorry for our late reaction. |
|
i haven't checked the correctness of the comment, but I don't see why we shouldn't also update private utils like this one |
|
I agree with both points raised by @jnothman and @NicolasHug. Let's focus on public estimators first. |
|
@happilyeverafter95 Feel free to pick up any other docstring from the list (which is an estimator). |
|
Sorry if my comment wasn't clear, but I was suggesting that the PR is IMO relevant and the changes should be considered |
|
Oh no, it is me that did not read correctly your comment. Sorry about that. Let's reopen and merge |
glemaitre
left a comment
There was a problem hiding this comment.
This can be merged when CIs are green.
Reference Issues/PRs
Addresses part of #15222
What does this implement/fix? Explain your changes.
This PR changes the documentation for
random_choice_cscby documenting which parts of the algorithm was randomized.Any other comments?