DOC Add version_added label for impute module#15549
DOC Add version_added label for impute module#15549glemaitre merged 6 commits intoscikit-learn:masterfrom
Conversation
sklearn/impute/_base.py
Outdated
|
|
||
| Read more in the :ref:`User Guide <impute>`. | ||
|
|
||
| .. versionadded:: 0.14 |
There was a problem hiding this comment.
This has only been available as SimpleImputer since 0.20
versionadded helps users understand whether the same tool can be imported in different versions, so the fact that the functionality existed since 0.14 is irrelevant
There was a problem hiding this comment.
That's clear.
Maybe we could mention it ? with something like:
| .. versionadded:: 0.14 | |
| .. versionadded:: 0.20 | |
| Moved from Imputer in sklearn.preprocessing. |
There was a problem hiding this comment.
At first, I was not convinced about mentioning this detail. But after seeing a lot of SO question, I think this worth mentioning something.
.. versionadded:: 0.20
`SimpleImputer` replaces the previous `sklearn.preprocessing.Imputer`
estimator which is now removed.
glemaitre
left a comment
There was a problem hiding this comment.
@TwsThomas Could you make the change I think that we could merge it after.
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Waiting for the CI to be merged.
|
Thanks @TwsThomas |
Reference Issues/PRs
Fixes partially #15426
What does this implement/fix? Explain your changes.
Update the version added tag for the imputer class.
Any other comments?
Might be part of the PR #15482 ?