[MRG] DOC add minimal example to multioutput.ClassifierChain#15211
Merged
glemaitre merged 13 commits intoscikit-learn:masterfrom Jun 17, 2020
Merged
[MRG] DOC add minimal example to multioutput.ClassifierChain#15211glemaitre merged 13 commits intoscikit-learn:masterfrom
glemaitre merged 13 commits intoscikit-learn:masterfrom
Conversation
Co-Authored-By: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-Authored-By: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Contributor
|
@adrinjalali open |
adrinjalali
approved these changes
Mar 2, 2020
Member
adrinjalali
left a comment
There was a problem hiding this comment.
Otherwise LGTM, thanks @ThorbenJensen
Member
|
@ThorbenJensen do you plan to continue working on this PR? |
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Contributor
Author
|
@marenwestermann |
cmarmo
approved these changes
May 22, 2020
Contributor
cmarmo
left a comment
There was a problem hiding this comment.
LGTM apart for the suggestions that will fix the errors in testing the docstrings.
Thanks @ThorbenJensen!
sklearn/multioutput.py
Outdated
| [1., 0., 0.], | ||
| [0., 1., 0.]]) | ||
| >>> chain.predict_proba(X_test) | ||
| array([[0.8387... , 0.9431... , 0.4576... ], |
Contributor
There was a problem hiding this comment.
Suggested change
| array([[0.8387... , 0.9431... , 0.4576... ], | |
| array([[0.8387..., 0.9431..., 0.4576...], |
sklearn/multioutput.py
Outdated
| [0., 1., 0.]]) | ||
| >>> chain.predict_proba(X_test) | ||
| array([[0.8387... , 0.9431... , 0.4576... ], | ||
| [0.8878... , 0.3684... , 0.2640... ], |
Contributor
There was a problem hiding this comment.
Suggested change
| [0.8878... , 0.3684... , 0.2640... ], | |
| [0.8878..., 0.3684..., 0.2640...], |
sklearn/multioutput.py
Outdated
| >>> chain.predict_proba(X_test) | ||
| array([[0.8387... , 0.9431... , 0.4576... ], | ||
| [0.8878... , 0.3684... , 0.2640... ], | ||
| [0.0321... , 0.9935... , 0.0625... ]]) |
Contributor
There was a problem hiding this comment.
Suggested change
| [0.0321... , 0.9935... , 0.0625... ]]) | |
| [0.0321..., 0.9935..., 0.0625...]]) |
Member
|
Thanks @ThorbenJensen |
dsandeep0138
pushed a commit
to dsandeep0138/scikit-learn
that referenced
this pull request
Jun 21, 2020
…15211) Co-Authored-By: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
rubywerman
pushed a commit
to MLH-Fellowship/scikit-learn
that referenced
this pull request
Jun 24, 2020
…15211) Co-Authored-By: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…15211) Co-Authored-By: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
…15211) Co-Authored-By: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Relates to #3846
What does this implement/fix? Explain your changes.
Adds an example to the docstring of
multioutput.ClassifierChain.Any other comments?
The code example is a simplification of what is used here:
https://scikit-learn.org/stable/auto_examples/multioutput/plot_classifier_chain_yeast.html