DOC Improve API documentation of CalibratedClassifierCV#15134
Merged
thomasjpfan merged 11 commits intoscikit-learn:masterfrom Jun 2, 2020
Merged
DOC Improve API documentation of CalibratedClassifierCV#15134thomasjpfan merged 11 commits intoscikit-learn:masterfrom
thomasjpfan merged 11 commits intoscikit-learn:masterfrom
Conversation
Contributor
|
Hi @pspachtholz, so sorry, your PR got lost ... Please let us know if you are still interested in working on it. Maybe you could find some time to synchronize your branch with upstream/master? This page will tell you how to do that (if you don't know already). Thanks for your patience! |
Contributor
Author
|
@cmarmo Yes. I'd like to finish it and synchronized my branch. |
cmarmo
reviewed
May 30, 2020
Contributor
cmarmo
left a comment
There was a problem hiding this comment.
Thanks for your work @pspachtholz !
Two minor comments on my side.
@NicolasHug do you mind to have a look at this one? Thanks!
NicolasHug
approved these changes
May 30, 2020
Member
NicolasHug
left a comment
There was a problem hiding this comment.
thanks @pspachtholz
Looks good once @cmarmo 's suggestions are applied
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Contributor
|
Sorry @pspachtholz! I've skipped one digit... |
thomasjpfan
reviewed
Jun 1, 2020
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #15133, towards #3846
What does this implement/fix? Explain your changes.
for training and calibrating a classifier