Merged
Conversation
Member
pprett
commented
Nov 5, 2010
- new dense implementation of SGD (sgd/sgd_fast.pyx and sgd/sgd.py)
- moved sparse extension module from sgd/sparse/src to sgd/
- sgd/sgd_fast_sparse.pyx now imports declarations (LossFunctions) from sgd/sgd_fast.pxd
- new example: examples/sgd/covertype_dense_sgd.py to showcase dense SGD.
…and changed shape of intercept_ and coef_ accordingly.
See thread "Sharing Declarations Between Cython Modules" on the scikit-learn mailing list.
ImportError stil present.
Updated setup accordingly.
test cases refactored.
added dense SGD to documentation.
Added decision surface plot of iris dataset for sgd. changed covertype example.
raghavrv
pushed a commit
to raghavrv/scikit-learn
that referenced
this pull request
Jun 23, 2017
Update with master and fix merge conflicts
prismdata
pushed a commit
to prismdata/scikit-learn
that referenced
this pull request
Oct 28, 2020
Feature/agent
jeremiedbb
referenced
this pull request
in FrancoisPgm/scikit-learn
Sep 23, 2025
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.