MNT Do not calculate term frequency when max_features is None in CountVectorizer#14267
Merged
rth merged 1 commit intoscikit-learn:masterfrom Jul 5, 2019
qinhanmin2014:CountVectorizer-simplify
Merged
MNT Do not calculate term frequency when max_features is None in CountVectorizer#14267rth merged 1 commit intoscikit-learn:masterfrom qinhanmin2014:CountVectorizer-simplify
rth merged 1 commit intoscikit-learn:masterfrom
qinhanmin2014:CountVectorizer-simplify
Conversation
thomasjpfan
approved these changes
Jul 5, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A trivial improvement, at least not harmful.