[MRG] MAINT Pins pytest version#14242
Merged
rth merged 3 commits intoscikit-learn:masterfrom Jul 3, 2019
Merged
Conversation
rth
approved these changes
Jul 3, 2019
Member
rth
left a comment
There was a problem hiding this comment.
Thanks! As a workaround this works, but I think it would still be good to fix tests to be compatible with the latest pytest version if possible.
Member
Author
|
Last time the fix was to “wait till pytest fixes this” and after a few days it worked! 😅 |
Member
|
OK, let's merge to fix master and see if it'll be resolved with pytest 5.0.x bugfix releases. |
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After pytest was updated to
5.0.0there has been errors such as: https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=4635This happened before when pytest was updated from
3.*to4.*. This PR pins the pytest version to3.*for python 3.5 (the newest version available on conda) and4.*on the latest python version.