DOC make explicit that groups required *Group* splitter#14235
Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom Jul 2, 2019
Merged
DOC make explicit that groups required *Group* splitter#14235thomasjpfan merged 1 commit intoscikit-learn:masterfrom
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
1ba69b9 to
c0e3f60
Compare
jnothman
approved these changes
Jul 2, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
Thanks for this. Our handling of groups is a bit inconsistent with how we handle sample_weight, which will raise an error if passed and not used. We should probably be raising a warning in other splitters when groups is passed.
thomasjpfan
reviewed
Jul 2, 2019
thomasjpfan
approved these changes
Jul 2, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jul 23, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11406
Make explicit that the parameter
groupsrequires Group splitter frommodel_selection.