FIX silence warning in IterativeImputer when constant feature in data#14234
Merged
thomasjpfan merged 1 commit intoscikit-learn:masterfrom Jul 2, 2019
Merged
FIX silence warning in IterativeImputer when constant feature in data#14234thomasjpfan merged 1 commit intoscikit-learn:masterfrom
thomasjpfan merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
Author
|
@rth as well ;) |
jnothman
approved these changes
Jul 2, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
I can't think of a better solution, except perhaps to find constant columns (e.g. with np.ptp) and handle them specially.
Member
Author
|
Actually, the case of std. dev. equal to 0 was already covered in the code: https://github.com/scikit-learn/scikit-learn/pull/14234/files#diff-159cd18cad859590dab36b15d3e5c2baR438 The only thing missing was to catch the warning |
amueller
approved these changes
Jul 2, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Jul 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #14148
If a feature is constant, a
true_divideRuntimeWarningis raised. This PR silent it.ping @jnothman @sergeyf @adrinjalali