[MRG] Adds 32bit linux testing to CI#14225
Conversation
| -e OPENBLAS_NUM_THREADS=$OPENBLAS_NUM_THREADS | ||
| -e SKLEARN_SKIP_NETWORK_TESTS=$SKLEARN_SKIP_NETWORK_TESTS | ||
| i386/ubuntu:16.04 | ||
| sleep 1000000 |
There was a problem hiding this comment.
I've not seen this trick before!
There was a problem hiding this comment.
Actually I do not understand: why are the subsequent steps being executed before the completion of this step?
Edit:
Oh I seed, you used the -d flag to detach the container and let it run in the background. Maybe you could explain this with a comment.
There was a problem hiding this comment.
Added a comment about using detached along with using -detach to be more explicit.
There was a problem hiding this comment.
If the installed version of sleep supports units other than seconds, please specify in minutes.
| displayName: 'Test Library' | ||
| - task: PublishTestResults@2 | ||
| inputs: | ||
| testResultsFiles: '$(TEST_DIR)/$(JUNITXML)' |
There was a problem hiding this comment.
I'm confused about how this accesses the docker container
There was a problem hiding this comment.
The $TEST_DIR is mapped into to the containers /temp_dir, so the junit xml generated by pytest will be place correctly into $TEST_DIR for the host to see.
|
The |
|
Should this pr skip test_gradient_and_hessian_sanity in 32 bit so it can be merged? |
rth
left a comment
There was a problem hiding this comment.
Very nice! I agree we should probably mark the failing test a know failure on 32 bit arch and open an issue about it.
|
PR updated with skipping |
|
Great, thanks @thomasjpfan ! |
|
@rth Next time I'll be more specific in saying this is for Azure. 😅 |
Aww yes, sorry it was a long day :) (also they do both start by an A) |
Reference Issues/PRs
Closes #9352
What does this implement/fix? Explain your changes.
Uses docker to run tests on 32bit linux.
Any other comments?
Besides the known 32bit failure:
test_extract_xi. This PR finds another error intest_gradient_and_hessian_sanity.