Skip to content

[MRG] Fix overlapped plot in the ICA example#14213

Merged
TomDLT merged 2 commits intoscikit-learn:masterfrom
h4iku:fix-example
Jun 28, 2019
Merged

[MRG] Fix overlapped plot in the ICA example#14213
TomDLT merged 2 commits intoscikit-learn:masterfrom
h4iku:fix-example

Conversation

@h4iku
Copy link
Copy Markdown
Contributor

@h4iku h4iku commented Jun 28, 2019

The plot headings in the FastICA example are mingled together and the bottom part of the plot is a bit out of view.

Before:

Figure_1

After:

Figure_2

@TomDLT
Copy link
Copy Markdown
Member

TomDLT commented Jun 28, 2019

Thanks for the fix !

I would personally prefer removing the subplots_adjust and add plt.tight_layout(), which makes everything work automatically.

@h4iku
Copy link
Copy Markdown
Contributor Author

h4iku commented Jun 28, 2019

You're right, I changed it to plt.tight_layout().

@TomDLT
Copy link
Copy Markdown
Member

TomDLT commented Jun 28, 2019

Awesome, thanks !

@TomDLT TomDLT merged commit 3ab22f9 into scikit-learn:master Jun 28, 2019
@h4iku h4iku deleted the fix-example branch June 28, 2019 18:13
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@h4iku @koenvandevelde
[MRG] Fix overlapped plot in the ICA example (scikit-learn#14213)
41f152d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomDLT TomDLT TomDLT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h4iku @TomDLT