Skip to content

MNT use relative imports in hist-gradient-boosting#14211

Merged
NicolasHug merged 1 commit intoscikit-learn:masterfrom
adrinjalali:mnt/hgb-relative-imports
Jun 28, 2019
Merged

MNT use relative imports in hist-gradient-boosting#14211
NicolasHug merged 1 commit intoscikit-learn:masterfrom
adrinjalali:mnt/hgb-relative-imports

Conversation

@adrinjalali
Copy link
Copy Markdown
Member

This is just a cleanup, I noticed the absolute imports in sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py, and the other files in the module seem fine in this regard.

@adrinjalali adrinjalali requested a review from NicolasHug June 28, 2019 14:32
Copy link
Copy Markdown
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit 71bc5ab into scikit-learn:master Jun 28, 2019
@adrinjalali adrinjalali deleted the mnt/hgb-relative-imports branch June 30, 2019 11:17
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants