Do not open file write file until download is complete.#140
Merged
GaelVaroquaux merged 1 commit intoscikit-learn:masterfrom Apr 29, 2011
Merged
Do not open file write file until download is complete.#140GaelVaroquaux merged 1 commit intoscikit-learn:masterfrom
GaelVaroquaux merged 1 commit intoscikit-learn:masterfrom
Conversation
Member
|
Ok this will load 200Mb in memory. If this ever causes a problem we should implement downloading to a temporary file and rename it to the right location at the end of the download instead, or delete it in case of failure. |
This way we avoid (or more precisely minimize) the need to deal with partially downloaded files and the errors that arise when you Control-C a started download.
Member
Author
|
Doesn't it always load 200mb in memory when .read() is called ? |
Member
|
Yes off-course, you are right. Please feel free to merge. |
Member
|
I think that 200Mb is OK nowadays. |
Member
|
And besides, Fabian is right, it is used anyhow, sorry for the noise. I'll merge. |
GaelVaroquaux
added a commit
that referenced
this pull request
Apr 29, 2011
Do not open file write file until download is complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ogrisel: is this OK?
This way we avoid (or more precisely minimize) the need to deal with
partially downloaded files and the errors that arise when you
Control-C a started download.