Merged
Conversation
- missing *.tp files (cython templates) from MANIFST.in - missing __init__.py file to turn a tests folder into a package to be shipped with the tarball
Member
Author
|
Related: #13861. |
rth
approved these changes
May 10, 2019
Member
|
If not our ci then our release process/docs. Sorry for not checking. |
jnothman
approved these changes
May 11, 2019
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 14, 2019
- missing *.tp files (cython templates) from MANIFST.in - missing __init__.py file to turn a tests folder into a package to be shipped with the tarball
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 14, 2019
- missing *.tp files (cython templates) from MANIFST.in - missing __init__.py file to turn a tests folder into a package to be shipped with the tarball
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
- missing *.tp files (cython templates) from MANIFST.in - missing __init__.py file to turn a tests folder into a package to be shipped with the tarball
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__init__.pyfile to turn a tests folder into a package tobe shipped with the tarball
Fix #13859.
Note: we probably need to improve our CI to also test for the installation of the generated tarball.