DOC Remove experimental tag from ColumnTransformer#13835
Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom May 9, 2019
qinhanmin2014:experimental-feature
Merged
DOC Remove experimental tag from ColumnTransformer#13835qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom qinhanmin2014:experimental-feature
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom
qinhanmin2014:experimental-feature
Conversation
jnothman
approved these changes
May 9, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
I think we are happy enough with the ColumnTransformer API so far... but of course we will be proven wrong some time soon...?
Member
|
IMO +1. The issues that I now see are more additional features than API changes. |
glemaitre
approved these changes
May 9, 2019
ogrisel
approved these changes
May 9, 2019
Member
ogrisel
left a comment
There was a problem hiding this comment.
+1 as well but would love to get @jorisvandenbossche's confirmation.
Member
|
Perhaps we should also note this in what's new in case some users have
avoided it
|
Member
|
I'm giving this 8 hours... if we've not heard other opinions, I think it's reasonable to merge and release. |
Member
jorisvandenbossche
left a comment
There was a problem hiding this comment.
We didn't any major issues being reported, I think, so +1 on removing the experimental tag.
jorisvandenbossche
approved these changes
May 9, 2019
Member
Author
|
Let's merge and release. |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 9, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @jnothman