Skip to content

[MRG] DOC Added version information for PCA.singular_values_#13776

Merged
jnothman merged 2 commits intoscikit-learn:masterfrom
olegstikhin:master
May 4, 2019
Merged

[MRG] DOC Added version information for PCA.singular_values_#13776
jnothman merged 2 commits intoscikit-learn:masterfrom
olegstikhin:master

Conversation

@olegstikhin
Copy link
Copy Markdown
Contributor

PCA.singular_values_ is added in 0.19; adding this information to the documentation.

Reference Issues/PRs

The feature PCA.singular_values_ has originally been implemented in #7685, however, the version information (0.19) is absent from the documentation.

What does this implement/fix? Explain your changes.

Adding information about the versioning, especially suitable for the users of older versions.

Any other comments?

PCA.singular_values_ is added in 0.19; adding this information to the documentation.
In decomposition/pca.py, removed the whitespaces from the empty line introduced by the previous commit.
@olegstikhin olegstikhin changed the title Added version information for PCA.singular_values_ [MRG] DOC Added version information for PCA.singular_values_ May 3, 2019
@jnothman
Copy link
Copy Markdown
Member

jnothman commented May 4, 2019

Thanks

@jnothman jnothman merged commit f84a5fe into scikit-learn:master May 4, 2019
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request May 6, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants