[MRG+1] add example to IsotonicRegression class#13768
Merged
jnothman merged 3 commits intoscikit-learn:masterfrom May 4, 2019
Merged
[MRG+1] add example to IsotonicRegression class#13768jnothman merged 3 commits intoscikit-learn:masterfrom
jnothman merged 3 commits intoscikit-learn:masterfrom
Conversation
adrinjalali
reviewed
May 2, 2019
sklearn/isotonic.py
Outdated
| Correctness of Kruskal's algorithms for monotone regression with ties | ||
| Leeuw, Psychometrica, 1977 | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
please remove one of these empty lines
jnothman
reviewed
May 3, 2019
Member
jnothman
left a comment
There was a problem hiding this comment.
Would predicting a couple more points make it clearer that the model is isotonic?
Contributor
Author
I could add some more points, but I tried and it doesn't show on a really small datasets like this one |
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 6, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3846
this PR adds an example to IsotonicRegression class
ping @adrinjalali