TST use approximate equality for float comparison in cross_val_predict tests#13749
Merged
jnothman merged 1 commit intoscikit-learn:masterfrom Apr 30, 2019
Merged
TST use approximate equality for float comparison in cross_val_predict tests#13749jnothman merged 1 commit intoscikit-learn:masterfrom
jnothman merged 1 commit intoscikit-learn:masterfrom
Conversation
Merged
Member
Author
|
This fixes the issue. Compare https://travis-ci.org/MacPython/scikit-learn-wheels/jobs/526407978 and https://travis-ci.org/MacPython/scikit-learn-wheels/jobs/526392063. Approve it? |
qinhanmin2014
approved these changes
Apr 30, 2019
Member
Author
|
I'm sure this is uncontroversial. I'll merge. |
jnothman
added a commit
that referenced
this pull request
Apr 30, 2019
Member
|
+1 (too late :) |
marcelobeckmann
pushed a commit
to marcelobeckmann/scikit-learn
that referenced
this pull request
May 1, 2019
marcelobeckmann
pushed a commit
to marcelobeckmann/scikit-learn
that referenced
this pull request
May 1, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.