fix note range in contributing.html#13722
Merged
qinhanmin2014 merged 2 commits intoscikit-learn:masterfrom May 5, 2019
Merged
Conversation
Member
|
It doesn't seem to be fixed looking at the generated docs https://56141-843222-gh.circle-artifacts.com/0/doc/developers/contributing.html |
Author
|
Sorry I didn't check it. |
Member
|
There are 2 things going on:
|
Author
|
Thanks for the kind help! |
Member
|
Worked like a charm, thanks! |
NicolasHug
approved these changes
Apr 29, 2019
qinhanmin2014
approved these changes
May 5, 2019
Member
qinhanmin2014
left a comment
There was a problem hiding this comment.
LGTM, thanks @kevin1kevin1k
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
May 6, 2019
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #13721
What does this implement/fix? Explain your changes.
Fix the range of the note
Any other comments?