MNT Minor clean up in OneVsOneClassifier#13677
Merged
NicolasHug merged 6 commits intoscikit-learn:masterfrom Apr 22, 2019
qinhanmin2014:OneVsOneClassifier
Merged
MNT Minor clean up in OneVsOneClassifier#13677NicolasHug merged 6 commits intoscikit-learn:masterfrom qinhanmin2014:OneVsOneClassifier
NicolasHug merged 6 commits intoscikit-learn:masterfrom
qinhanmin2014:OneVsOneClassifier
Conversation
jnothman
approved these changes
Apr 21, 2019
NicolasHug
approved these changes
Apr 21, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
LGTM but I don't see this attribute being described in any docstring. Should it be private?
Member
Author
I guess it's not easy to make things private, even for those things which are not documented. |
NicolasHug
reviewed
Apr 21, 2019
Co-Authored-By: qinhanmin2014 <qinhanmin2005@sina.com>
jnothman
reviewed
Apr 21, 2019
jnothman
reviewed
Apr 21, 2019
sklearn/multiclass.py
Outdated
| classes_ : numpy array of shape [n_classes] | ||
| Array containing labels. | ||
|
|
||
| pairwise_indices_ : list, length = ``n_classes * (n_classes - 1) / 2``, |
Member
There was a problem hiding this comment.
This needs a \ at the end for the line continuation to render correctly
Member
There was a problem hiding this comment.
But you can just use len(estimators_) here for brevity
Member
|
Merging, it looks like |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 0ccf60c.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 0ccf60c.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use getattr to get _pairwise so we won't get AttributeError.