[MRG] Removed synonyms in docs linear_model#13663
Merged
TomDLT merged 5 commits intoscikit-learn:masterfrom Apr 18, 2019
Merged
[MRG] Removed synonyms in docs linear_model#13663TomDLT merged 5 commits intoscikit-learn:masterfrom
TomDLT merged 5 commits intoscikit-learn:masterfrom
Conversation
NicolasHug
approved these changes
Apr 17, 2019
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Some suggestions but no strong opinion
LGTM anyway, this is already a very clear improvement!
Thanks @tommyod
Co-Authored-By: tommyod <10076072+tommyod@users.noreply.github.com>
…learn into docs_readthrough
Contributor
Author
|
Thanks for the fast review @NicolasHug, appreciate it. Everything I agree with I've changed. I left some point unresolved if you'd like to discuss them further. I don't mind making a new round of changes if you have more comments. |
TomDLT
approved these changes
Apr 18, 2019
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…-learn#13663)" This reverts commit d80545d.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…-learn#13663)" This reverts commit d80545d.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are quite a few synonyms in use in the docs. In this PR I read through
linear_model.rstand:\text{word}instead ofwordin LaTeX.Some of this is a bit opinionated, so I would appreciate feedback. This PR closes #13639.