Skip to content

[MRG] DOC Fixes formatting issue in webkit#13657

Merged
agramfort merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:css-hyphens
Apr 17, 2019
Merged

[MRG] DOC Fixes formatting issue in webkit#13657
agramfort merged 1 commit intoscikit-learn:masterfrom
thomasjpfan:css-hyphens

Conversation

@thomasjpfan
Copy link
Copy Markdown
Member

Fixes #12793

@jnothman
Copy link
Copy Markdown
Member

That has to do with hyphenation?

@thomasjpfan
Copy link
Copy Markdown
Member Author

https://55109-843222-gh.circle-artifacts.com/0/doc/modules/generated/sklearn.base.ClusterMixin.html#sklearn.base.ClusterMixin

That has to do with hyphenation?

Yes and it only happens on webkit (for now). I do not know if webkit or mozilla is implementing the spec correctly, thus this PR turns off hyphenation on the longtable class for all browsers. Only for the longtable class is changed to reduce scope of this css change.

@agramfort agramfort merged commit 2e6b6ea into scikit-learn:master Apr 17, 2019
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Apr 25, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document display visual bug

3 participants